linux-kernel - Re: [PATCH v2] ata: add AMD Seattle platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56E9BE45.8030101@amd.com>
Date:	Wed, 16 Mar 2016 15:12:53 -0500
From:	Brijesh Singh <brijesh.singh@....com>
To:	Hans de Goede <hdegoede@...hat.com>, Tejun Heo <tj@...nel.org>
CC:	<brijesh.singh@....com>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <linux-ide@...r.kernel.org>
Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver

Hi Tejun,


On 01/26/2016 03:36 AM, Hans de Goede wrote:
> Hi,
> 
> On 25-01-16 21:43, Tejun Heo wrote:
>> On Thu, Jan 14, 2016 at 10:31:11AM -0600, Brijesh Singh wrote:
>>> AMD Seattle SATA controller mostly conforms to AHCI interface with some
>>> special register to control SGPIO interface. In the case of an AHCI
>>> controller, the SGPIO feature is ideally implemented using the
>>> "Enclosure Management" register of the AHCI controller, but those
>>> registeres are not implemented in the Seattle SoC. Instead SoC
>>> (Rev B0 onwards) provides a 32-bit SGPIO control register which should
>>> be programmed to control the activity, locate and fault LEDs.
>>>
>>> The driver is based on ahci_platform driver.
>>>
>>> Signed-off-by: Brijesh Singh <brijesh.singh@....com>
>>> Acked-by: Hans de Goede <hdegoede@...hat.com>
>>> CC: tj@...nel.org
>>> CC: linux-ide@...r.kernel.org
>>
>> Hans, can you please review the patch?
> 
> Done, driver looks good to me:
> 
> Acked-by: Hans de Goede <hdegoede@...hat.com>
>

Can we please pull this patch ? If needed then I can rebase to the tip. Given the current HW and BIOS limitation, platform driver seems like a right choice.

Thanks
Brijesh
 
> Regards,
> 
> Hans