linux-kernel - Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <F1BB73D3-C592-4476-91A9-0529B51C2156@gmail.com>
Date:	Wed, 16 Mar 2016 22:55:53 +0100
From:	Julien Chauveau <chauveau.julien@...il.com>
To:	Javier Martinez Canillas <javier@...hile0.org>
Cc:	Andreas Färber <afaerber@...e.de>,
	linux-input@...r.kernel.org, Heiko Stuebner <heiko@...ech.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example


> Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@...hile0.org> a écrit :
> 
> Hello Andreas,
> 
> On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@...e.de> wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>> 
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>> 
>> While at it, adopt the dashes convention for the node name.
>> 
>> Reported-by: Julien Chauveau <chauveau.julien@...il.com>
>> Cc: Julien Chauveau <chauveau.julien@...il.com>
>> Cc: Javier Martinez Canillas <javier@...hile0.org>
>> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Signed-off-by: Andreas Färber <afaerber@...e.de>
>> ---
> 
> Patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

I agree.

Reviewed-by: Julien Chauveau <chauveau.julien@...il.com>