[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdWkeV34DpJO3Q_kviO9u0cBdYvSQ_34=UAkOmHLsisYjw@mail.gmail.com>
Date: Thu, 17 Mar 2016 08:34:05 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Linus Walleij <linus.walleij@...aro.org>,
Magnus <magnus.damm@...il.com>, Simon <horms@...ge.net.au>,
linux-renesas-soc@...r.kernel.org,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL
for debug
Hi Morimoto-san,
On Thu, Mar 17, 2016 at 1:30 AM, Kuninori Morimoto
<kuninori.morimoto.gx@...esas.com> wrote:
>> > From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
>> >
>> > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug.
>> > Of course we can get it from indicated register address, but it
>> > is not convenient. This patch enables to indicate these.
>> >
>> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
>>
>> > --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
>> > +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
>> > @@ -94,6 +94,7 @@ struct pinmux_func {
>> > };
>> >
>> > struct pinmux_cfg_reg {
>> > + const char *name;
>>
>> Have you looked at the size increase, esp. for multi-platform kernels?
>
> Indeed.
> I checked its size by "ls -l", and the result is below.
> zImage size was... reduced ??
>
> without this patch
>
> 10661888 Image
> 3544032 zImage
>
> with this patch
>
> 10661888 Image
> 3543432 zImage
Please use "size drivers/pinctrl/sh-pfc/built-in.o".
zImage size is affected by section alignment and crompression.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists