linux-kernel - Re: [PATCH] Add tw5864 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160317075731.GC25216@leon.nu>
Date:	Thu, 17 Mar 2016 09:57:31 +0200
From:	Leon Romanovsky <leon@...n.nu>
To:	Andrey Utkin <andrey_utkin@...tmail.com>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bluecherry Maintainers <maintainers@...echerrydvr.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Kalle Valo <kvalo@...eaurora.org>,
	Joe Perches <joe@...ches.com>, Jiri Slaby <jslaby@...e.com>,
	devel@...verdev.osuosl.org, kernel-mentors@...enic.com,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] Add tw5864 driver

On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote:
> From: Andrey Utkin <andrey.utkin@...p.bluecherry.net>
> 
> Support for boards based on Techwell TW5864 chip which provides
> multichannel video & audio grabbing and encoding (H.264, MJPEG,
> ADPCM G.726).
> 
> Signed-off-by: Andrey Utkin <andrey.utkin@...p.bluecherry.net>
> Tested-by: Andrey Utkin <andrey.utkin@...p.bluecherry.net>
> ---
>  MAINTAINERS                                  |    7 +
>  drivers/staging/media/Kconfig                |    2 +
>  drivers/staging/media/Makefile               |    1 +
>  drivers/staging/media/tw5864/Kconfig         |   11 +
>  drivers/staging/media/tw5864/Makefile        |    3 +
>  drivers/staging/media/tw5864/tw5864-bs.h     |  154 ++
>  drivers/staging/media/tw5864/tw5864-config.c |  359 +++++
>  drivers/staging/media/tw5864/tw5864-core.c   |  453 ++++++
>  drivers/staging/media/tw5864/tw5864-h264.c   |  183 +++
>  drivers/staging/media/tw5864/tw5864-reg.h    | 2200 ++++++++++++++++++++++++++
>  drivers/staging/media/tw5864/tw5864-tables.h |  237 +++
>  drivers/staging/media/tw5864/tw5864-video.c  | 1364 ++++++++++++++++
>  drivers/staging/media/tw5864/tw5864.h        |  280 ++++
>  include/linux/pci_ids.h                      |    1 +
>  14 files changed, 5255 insertions(+)
>  create mode 100644 drivers/staging/media/tw5864/Kconfig
>  create mode 100644 drivers/staging/media/tw5864/Makefile
>  create mode 100644 drivers/staging/media/tw5864/tw5864-bs.h
>  create mode 100644 drivers/staging/media/tw5864/tw5864-config.c
>  create mode 100644 drivers/staging/media/tw5864/tw5864-core.c
>  create mode 100644 drivers/staging/media/tw5864/tw5864-h264.c
>  create mode 100644 drivers/staging/media/tw5864/tw5864-reg.h
>  create mode 100644 drivers/staging/media/tw5864/tw5864-tables.h
>  create mode 100644 drivers/staging/media/tw5864/tw5864-video.c
>  create mode 100644 drivers/staging/media/tw5864/tw5864.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 409509d..7bb1fa9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11195,6 +11195,13 @@ T:	git git://linuxtv.org/media_tree.git
>  S:	Odd fixes
>  F:	drivers/media/usb/tm6000/
>  
> +TW5864 VIDEO4LINUX DRIVER
> +M:	Bluecherry Maintainers <maintainers@...echerrydvr.com>

I wonder if this the right thing to do. Generally speaking a maintainer is a
person and not a corporate.

> +M:	Andrey Utkin <andrey.utkin@...p.bluecherry.net>
> +L:	linux-media@...r.kernel.org
> +S:	Supported
> +F:	drivers/staging/media/tw5864/

<snip>

> +
> --- /dev/null
> +++ b/drivers/staging/media/tw5864/tw5864-bs.h
> @@ -0,0 +1,154 @@
> +/*
> + *  TW5864 driver - Exp-Golomb code functions
> + *
> + *  Copyright (C) 2015 Bluecherry, LLC <maintainers@...echerrydvr.com>
> + *  Author: Andrey Utkin <andrey.utkin@...p.bluecherry.net>

You don't need to state your name here. It is written in git log.