linux-kernel - Re: [PATCH v3 0/2] Livepatch module notifier cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1603170950000.3656@cbobk.fhfr.pm>
Date:	Thu, 17 Mar 2016 09:50:28 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	Jessica Yu <jeyu@...hat.com>
cc:	Josh Poimboeuf <jpoimboe@...hat.com>,
	Miroslav Benes <mbenes@...e.cz>,
	Petr Mladek <pmladek@...e.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Steven Rostedt <rostedt@...dmis.org>,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] Livepatch module notifier cleanup

On Wed, 16 Mar 2016, Jessica Yu wrote:

> These are the remaining 2 patches that came from the original ftrace/livepatch
> module notifier patchset found here: https://lkml.org/lkml/2016/2/8/1180
> 
> Basically, the patchset does a bit of module.c cleanup (patch 1) in
> preparation for the klp_module_{coming,going} calls (patch 2). We decided
> to stop relying on the module notifier callchain in favor of hard-coding
> the appropriate livepatch function calls that handle coming and going
> modules. Hard-coding these calls will guarantee that ftrace and livepatch
> exit/initialization routines are called in the correct order without
> relying on module notifiers.
> 
> The patches should be nearly exactly the same as those from the previous
> discussion, except in patch 2 I've added back the #if IS_ENABLED(CONFIG_LIVEPATCH)
> guard in livepatch.h.
> 
> Patches based on linux-next.
> 
> v2 discussion found here:
> https://lkml.kernel.org/g/1457726628-9171-1-git-send-email-jeyu@redhat.com 
> 
> v3:
>  - Remove confusing comment above klp_module_going()
>  - Place prepare_coming_module() after complete_formation()
>  - Fix small race in klp_module_coming() by setting mod->klp_alive
>    to false in the error path

I've applied v3 to for-4.6/notifier-cleanup.

Thanks!

-- 
Jiri Kosina
SUSE Labs