linux-kernel - Re: [PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGRGNgXEfvSuxLZ3Qrb3hj7DK89qBKX3Bh2+0Ov9FZX+4_PqOw@mail.gmail.com>
Date:	Thu, 17 Mar 2016 20:18:59 +1100
From:	Julian Calaby <julian.calaby@...il.com>
To:	Jandy Gou <qingsong.gou@...telecom.com>,
	Jes Sorensen <Jes.Sorensen@...hat.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Greg KH <gregkh@...uxfoundation.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: r8723au: This patch tries to fix some byte order
 issues that is found by sparse check.

Hi Jandy,

On Thu, Mar 17, 2016 at 7:03 PM, Jandy Gou <qingsong.gou@...telecom.com> wrote:
> make C=1 M=drivers/staging/rtl8723au/
>
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to
> restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to
> restricted __le32
>
> Signed-off-by: Jandy Gou <qingsong.gou@...telecom.com>

I'm not sure your change is correct. Perhaps you should add temporary
variables for h2c_cmd_ex and h2c_cmd while they're cpu-endian?

Jes,

I'm pretty sure this isn't the first time this has come up. Do you
have any ideas for a solution? Or should we ignore this as this driver
will eventually be going away?

Thanks,

Julian Calaby

> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> index 1662c03c..d82fd8a 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
> @@ -93,11 +93,11 @@ int FillH2CCmd(struct rtw_adapter *padapter, u8 ElementID, u32 CmdLen,
>
>                 if (h2c_cmd & BIT(7)) {
>                         msgbox_ex_addr = REG_HMEBOX_EXT_0 + (h2c_box_num * EX_MESSAGE_BOX_SIZE);
> -                       h2c_cmd_ex = le16_to_cpu(h2c_cmd_ex);
> +                       le16_to_cpus(&h2c_cmd_ex);
>                         rtl8723au_write16(padapter, msgbox_ex_addr, h2c_cmd_ex);
>                 }
>                 msgbox_addr = REG_HMEBOX_0 + (h2c_box_num * MESSAGE_BOX_SIZE);
> -               h2c_cmd = le32_to_cpu(h2c_cmd);
> +               le32_to_cpus(&h2c_cmd);
>                 rtl8723au_write32(padapter, msgbox_addr, h2c_cmd);
>
>                 bcmd_down = true;
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/