linux-kernel - Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2016 09:54:38 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Harry Pan <harry.pan@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Harry Pan <gs0622@...il.com>,
	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

On Wed, Mar 16, 2016 at 07:17:51PM +0800, Harry Pan wrote:

> Conflicts:
> 	sound/soc/soc-dapm.c

Don't include noise like this in upstream submissions.

> +	if (!strcmp(cmpnt->name, "snd-soc-dummy"))
> +		return 0;
> +

This doesn't make much sense and is going to be very fragile.  We
should either make the dummy component look like other components or
make the code cope with them as they stand, that way we don't have
random undocumented special cases scattered through the code.  Probably
it's better to make the dummy component look like others.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)