linux-kernel - Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160317112514.GE2566@sirena.org.uk>
Date:	Thu, 17 Mar 2016 11:25:14 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Pan, Harry" <harry.pan@...el.com>
Cc:	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"gs0622@...il.com" <gs0622@...il.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"tiwai@...e.com" <tiwai@...e.com>,
	"perex@...ex.cz" <perex@...ex.cz>
Subject: Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

On Thu, Mar 17, 2016 at 10:38:36AM +0000, Pan, Harry wrote:

> Allow me to explain more detail that I saw during debug; since the
> commit 6e78108bda78 (ASoC: core: Don't probe the component which is
> dummy), an exception has been made that dummy component won't be probed,
> thus the 'card' passed into soc_probe_component() would not be assigned
> to this component. In the other hand, the component struct is initially
> created in snd_soc_register_platform() by kzalloc() of platform struct,
> its 'card' pointer is remaining an NULL pointer even the widget node
> being read.

> Perhaps another option is to refine soc_probe_component(), which I have
> not dive in.

Another approach might be to create a separate dummy component for each
card rather than trying to reuse the same one for all of them (which was
what the commit you mention was doing) - that way we don't need to worry
about it getting added to multiple cards which was the original problem
that was being looked at here.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)