linux-kernel - Re: [PATCH v2 all 04/14] arc: use of_platform_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C2D7FE5348E1B147BCA15975FBA23075F4E903CE@us01wembx1.internal.synopsys.com>
Date:	Thu, 17 Mar 2016 11:29:13 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Kefeng Wang <wangkefeng.wang@...wei.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"arnd@...db.de" <arnd@...db.de>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>,
	"catalin.marinas@....com" <catalin.marinas@....com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"olof@...om.net" <olof@...om.net>,
	"yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
	"guohanjun@...wei.com" <guohanjun@...wei.com>,
	Vineet Gupta <Vineet.Gupta1@...opsys.com>
Subject: Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to
 populate default bus

On Wednesday 16 March 2016 01:03 PM, Kefeng Wang wrote:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
>
> Acked-by: Vineet Gupta <vgupta@...opsys.com>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Thx Kefeng. I've added this to ARC for-curr for 4.6

> ---
>  arch/arc/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index cdc821d..401f51f 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -464,7 +464,7 @@ static int __init customize_machine(void)
>  	 * Traverses flattened DeviceTree - registering platform devices
>  	 * (if any) complete with their resources
>  	 */
> -	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> +	of_platform_default_populate(NULL, NULL, NULL);

Perhaps too late - but can't of_platform_default_populate just be a static inline
calling of_platform_populate in the header rather than exporting yet another symbol !

-Vineet

>  
>  	if (machine_desc->init_machine)
>  		machine_desc->init_machine();