lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Mar 2016 15:38:57 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: David Lechner <david@...hnology.com> Cc: Petr Kulhavy <petr@...ix.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Russell King <linux@....linux.org.uk>, Sekhar Nori <nsekhar@...com>, Kevin Hilman <khilman@...nel.org>, Kishon Vijay Abraham I <kishon@...com>, Alan Stern <stern@...land.harvard.edu>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Bin Liu <b-liu@...com>, Andreas Färber <afaerber@...e.de>, Tony Lindgren <tony@...mide.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org Subject: Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY On 3/17/2016 5:26 AM, David Lechner wrote: > This is a new phy driver for the SoC USB controllers on the TI DA8XX DA8xx, please. > family of microcontrollers. The USB 1.1 PHY is just a simple on/off. > The USB 2.0 PHY also allows overriding the VBUS and ID pins. > > Signed-off-by: David Lechner <david@...hnology.com> [...] > diff --git a/drivers/phy/phy-da8xx-usb.c b/drivers/phy/phy-da8xx-usb.c > new file mode 100644 > index 0000000..93a5f4d > --- /dev/null > +++ b/drivers/phy/phy-da8xx-usb.c > @@ -0,0 +1,295 @@ [...] > +static inline u32 da8xx_usbphy_readl(void __iomem *base) > +{ > + return readl(base); > +} > + > +static inline void da8xx_usbphy_writel(void __iomem *base, u32 value) > +{ > + writel(value, base); Why wrap them at all? > +} > + > +static int da8xx_usb11_phy_init(struct phy *phy) > +{ > + struct da8xx_usbphy *d_phy = phy_get_drvdata(phy); > + int ret; > + u32 val; > + > + ret = clk_prepare_enable(d_phy->usb11_clk); > + if (ret) > + return ret; > + > + val = da8xx_usbphy_readl(d_phy->phy_ctrl); > + val |= USB1SUSPENDM; > + da8xx_usbphy_writel(d_phy->phy_ctrl, val); Hum, I'd think this needs to be done in the power_on() method... > + > + return 0; > +} > + > +static int da8xx_usb11_phy_shutdown(struct phy *phy) > +{ > + struct da8xx_usbphy *d_phy = phy_get_drvdata(phy); > + u32 val; > + > + val = da8xx_usbphy_readl(d_phy->phy_ctrl); > + val &= ~USB1SUSPENDM; > + da8xx_usbphy_writel(d_phy->phy_ctrl, val); And this in power_off()... > + > + clk_disable_unprepare(d_phy->usb11_clk); > + > + return 0; > +} > + > +static const struct phy_ops da8xx_usb11_phy_ops = { > + .power_on = da8xx_usb11_phy_init, > + .power_off = da8xx_usb11_phy_shutdown, Aha, it's just that the names don't match... Please call the implementations da8xx_usb11_phy_power_{on|off}(). The same with USB 2.0 PHY. [...] Looks good otherwise on my superficial review. :-) MBR, Sergei
Powered by blists - more mailing lists