linux-kernel - Re: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue() to alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458218602.2158.17.camel@sipsolutions.net>
Date:	Thu, 17 Mar 2016 13:43:22 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Eva Rachel Retuya <eraretuya@...il.com>,
	outreachy-kernel@...glegroups.com
Cc:	emmanuel.grumbach@...el.com, linuxwifi@...el.com,
	kvalo@...eaurora.org, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, tj@...nel.org
Subject: Re: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue()
 to alloc_workqueue()

On Thu, 2016-03-17 at 20:37 +0800, Eva Rachel Retuya wrote:
> Use alloc_workqueue() to allocate the workqueue instead of
> create_singlethread_workqueue() since the latter is deprecated and is
> scheduled for removal.

Scheduled where?

>  static void iwl_setup_deferred_work(struct iwl_priv *priv)
>  {
> -	priv->workqueue = create_singlethread_workqueue(DRV_NAME);
> +	priv->workqueue = alloc_workqueue(DRV_NAME, WQ_HIGHPRI |
> WQ_UNBOUND |
> +					  WQ_MEM_RECLAIM, 1);

Seems like you should use alloc_ordered_workqueue() though? That also
gets you UNBOUND immediately, and the "1".

I'm not really sure HIGHPRI is needed either.

johannes