linux-kernel - Re: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160317140430.GA26606@griffinp-ThinkPad-X1-Carbon-2nd>
Date:	Thu, 17 Mar 2016 14:04:30 +0000
From:	Peter Griffin <peter.griffin@...aro.org>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	patches@...aro.org, lee.jones@...aro.org,
	linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL
 pointer

Hi Heiko,

On Thu, 17 Mar 2016, Heiko Stübner wrote:

> Hi Peter,
> 
> no need to resend for that (will be lost when applying anyway), but for future 
> patches please consider the things below:
> 
> Am Donnerstag, 17. März 2016, 13:43:11 schrieb Peter Griffin:
> > This fixes the following sparse build warning:
> > 
> >      mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> 
> please bring aling tags received in previous versions to future ones, like the 
> one from Lee:
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>

Will do, I didn't notice Lee had also Acked it. I should have been paying more
attention and not re-spinning whilst in a conf call.
> 
> > ---
> 
> changes in v2:
> - beautify commit message
> 
> 
> otherwise, patch looks nice and I'll pick it up shortly
> 
> 
> Thanks for catching this

No problem, thanks for the feedback and taking the patch.

regards,

Peter.