linux-kernel - Re: rcutorture: Consider FROZEN hotplug notifier transitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160317150131.GS4287@linux.vnet.ibm.com>
Date:	Thu, 17 Mar 2016 08:01:31 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Anna-Maria Gleixner <anna-maria@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, rt@...utronix.de,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: rcutorture: Consider FROZEN hotplug notifier transitions

On Thu, Mar 17, 2016 at 11:14:35AM +0100, Anna-Maria Gleixner wrote:
> The hotplug notifier rcutorture_cpu_notify() doesn't consider the
> corresponding CPU_XXX_FROZEN transitions. They occure on
> suspend/resume and are usually handled the same way as the
> corresponding non frozen transitions.
> 
> Mask the switch case action argument with '~CPU_TASKS_FROZEN' to map
> CPU_XXX_FROZEN hotplug transitions on corresponding non frozen
> transitions.
> 
> Cc: Josh Triplett <josh@...htriplett.org>
> Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>

Queued for review and testing, thank you!  If all goes well, I will
push this into the 4.7 merge window (not the current one, but the
next one).

						Thanx, Paul

> ---
>  kernel/rcu/rcutorture.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -1598,7 +1598,7 @@ static int rcutorture_cpu_notify(struct
>  {
>  	long cpu = (long)hcpu;
> 
> -	switch (action) {
> +	switch (action & ~CPU_TASKS_FROZEN) {
>  	case CPU_ONLINE:
>  	case CPU_DOWN_FAILED:
>  		(void)rcutorture_booster_init(cpu);
>