[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 17 Mar 2016 09:00:14 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Kedareswara rao Appana <appana.durga.rao@...inx.com>
Cc: dan.j.williams@...el.com, vinod.koul@...el.com,
michal.simek@...inx.com, soren.brinkmann@...inx.com,
appanad@...inx.com, moritz.fischer@...us.com,
luis@...ethencourt.com, anirudh@...inx.com,
dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] dmaengine: xilinx_vdma: Fix checkpatch.pl warnings
Hello,
On Tuesday 15 March 2016 22:53:06 Kedareswara rao Appana wrote:
> This patch fixes the below checkpatch.pl warnings.
>
> WARNING: void function return statements are not generally useful
> + return;
> +}
>
> WARNING: void function return statements are not generally useful
> + return;
> +}
>
> WARNING: Missing a blank line after declarations
> + u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
> + vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,
>
> Signed-off-by: Kedareswara rao Appana <appanad@...inx.com>
Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
> drivers/dma/xilinx/xilinx_vdma.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_vdma.c
> b/drivers/dma/xilinx/xilinx_vdma.c index 0ee0321..7ab6793 100644
> --- a/drivers/dma/xilinx/xilinx_vdma.c
> +++ b/drivers/dma/xilinx/xilinx_vdma.c
> @@ -569,8 +569,6 @@ static void xilinx_vdma_halt(struct xilinx_vdma_chan
> *chan) chan, vdma_ctrl_read(chan, XILINX_VDMA_REG_DMASR));
> chan->err = true;
> }
> -
> - return;
> }
>
> /**
> @@ -595,8 +593,6 @@ static void xilinx_vdma_start(struct xilinx_vdma_chan
> *chan)
>
> chan->err = true;
> }
> -
> - return;
> }
>
> /**
> @@ -829,6 +825,7 @@ static irqreturn_t xilinx_vdma_irq_handler(int irq, void
> *data) * make sure not to write to other error bits to 1.
> */
> u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
> +
> vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,
> errors & XILINX_VDMA_DMASR_ERR_RECOVER_MASK);
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists