lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <56EAEB84.8060005@lechnology.com>
Date:	Thu, 17 Mar 2016 12:38:12 -0500
From:	David Lechner <david@...hnology.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Petr Kulhavy <petr@...ix.com>, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Sekhar Nori <nsekhar@...com>,
	Kevin Hilman <khilman@...nel.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bin Liu <b-liu@...com>, Tony Lindgren <tony@...mide.com>,
	Andreas Färber <afaerber@...e.de>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 11/11] usb: musb: da8xx: Remove mach code

On 03/17/2016 08:11 AM, Sergei Shtylyov wrote:
> On 3/17/2016 5:26 AM, David Lechner wrote:
>>
>>       glue->dev            = &pdev->dev;
>>       pdata->platform_ops        = &da8xx_ops;
>>
>> -    glue->phy = usb_phy_generic_register();
>> -    if (IS_ERR(glue->phy)) {
>> -        ret = PTR_ERR(glue->phy);
>> -        goto err5;
>> +    glue->usb_phy = usb_phy_generic_register();
>
>     Hm, do we still need the USB PHY? It does nothing IIRC...
>

Unfortunately, yes. It is used in musb_core, etc., mainly for otg->state.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ