linux-kernel - usb: gadget breakage on N900: bind UDC by name passed via usb_gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2016 22:26:03 +0100
From:	Pavel Machek <pavel@....cz>
To:	pali.rohar@...il.com, sre@...nel.org,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org,
	aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
	patrikbachan@...il.com, serge@...lyn.com,
	maxime.ripard@...e-electrons.com, ruslan.bilovol@...il.com,
	m.szyprowski@...sung.com, peter.chen@...escale.com, balbi@...com
Subject: usb: gadget breakage on N900: bind UDC by name passed via
 usb_gadget_driver structure

Hi!

USB gadget stops working for me on n900, if I merge

usb: gadget: bind UDC by name passed via usb_gadget_driver structure

patch.

commit 2284b29d3d9dd16490909962574d7f3fef83fd97
Author: Ruslan Bilovol <ruslan.bilovol@...il.com>
Date:   Mon Nov 23 09:56:35 2015 +0100

    usb: gadget: bind UDC by name passed via usb_gadget_driver
    structure

    Introduce new 'udc_name' member to usb_gadget_driver structure.
        The 'udc_name' is a name of UDC that usb_gadget_driver should
	    be bound to. If udc_name is NULL, it will be bound to any
	        available UDC.

    Tested-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
        Signed-off-by: Ruslan Bilovol <ruslan.bilovol@...il.com>
	    Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
	        Tested-by: Peter Chen <peter.chen@...escale.com>
		    Signed-off-by: Felipe Balbi <balbi@...com>


Patch is obvious enough... if there's someone who sets udc_name to
NULL. Who is supposed to do that?

(I have patch in my tree to make USB gadget work when it is not
modular).

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html