linux-kernel - Re: [PATCH] powercap: intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458255363.3861.40.camel@linux.intel.com>
Date:	Thu, 17 Mar 2016 15:56:03 -0700
From:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:	Borislav Petkov <bp@...e.de>
Cc:	rjw@...ysocki.net, linux-pm@...r.kernel.org, mingo@...hat.com,
	tglx@...utronix.de, x86@...nel.org, hpa@...or.com,
	linux-kernel@...r.kernel.org, jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH] powercap: intel_rapl: PSys support

On Thu, 2016-03-17 at 23:51 +0100, Borislav Petkov wrote:
> On Thu, Mar 17, 2016 at 03:23:29PM -0700, Srinivas Pandruvada wrote:
> > 
> > Skylake processor supports a new set of RAPL registers for
> > controlling
> > entire platform instead of just CPU package. This is useful for
> > thermal
> > and power control when source of power/thermal is not just CPU/GPU.
> > This change adds a new platform domain (AKA PSys) to the current
> > power capping Intel RAPL driver.
> > PSys also supports PL1 (long term) and PL2 (short term) control
> > like
> > package domain. This also follows same MSRs for energy and time
> > units as package domain.
> > Unlike package domain, PSys support requires more than just
> > processor
> > level implementation. The other parts in the system need additional
> > implementation, which OEMs needs to support. So not all Skylake
> > systems will support PSys.
> > 
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel
> > .com>
> > ---
> >  arch/x86/include/asm/msr-index.h |  3 ++
> >  drivers/powercap/intel_rapl.c    | 63
> > ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 66 insertions(+)
> > 
> > diff --git a/arch/x86/include/asm/msr-index.h
> > b/arch/x86/include/asm/msr-index.h
> > index 2da46ac..bd383f5 100644
> > --- a/arch/x86/include/asm/msr-index.h
> > +++ b/arch/x86/include/asm/msr-index.h
> > @@ -190,6 +190,9 @@
> >  #define MSR_PP1_ENERGY_STATUS		0x00000641
> >  #define MSR_PP1_POLICY			0x00000642
> >  
> > +#define MSR_PLATFORM_ENERGY_STATUS	0x0000064d
> > +#define MSR_PLATFORM_POWER_LIMIT	0x0000065c
> Please add those defines to intel_rapl.c as they're being used only
> there, apparently.
OK. I will move them.

Thanks,
Srinivas

> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
> HRB 21284 (AG Nürnberg)