linux-kernel - Re: [PATCH v2] efi: Introduce EFI bootloader control driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201603181906.5GOsM7Ot%fengguang.wu@intel.com>
Date:	Fri, 18 Mar 2016 19:22:09 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Daniel Baluta <daniel.baluta@...el.com>
Cc:	kbuild-all@...org, matt@...eblueprint.co.uk,
	linux-efi@...r.kernel.org, stefan.stanacar@...el.com,
	octavian.purdila@...el.com, daniel.baluta@...el.com,
	linux-kernel@...r.kernel.org, matthew.k.gumbel@...el.com,
	mohamed.abbas@...el.com, constantin.musca@...el.com
Subject: Re: [PATCH v2] efi: Introduce EFI bootloader control driver

Hi Matt,

[auto build test WARNING on efi/next]
[also build test WARNING on v4.5 next-20160318]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Daniel-Baluta/efi-Introduce-EFI-bootloader-control-driver/20160318-181048
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git next
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from include/linux/list.h:8,
                    from include/linux/preempt.h:10,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/efi.h:16,
                    from drivers/firmware/efi/efi-bc.c:15:
   drivers/firmware/efi/efi-bc.c: In function 'efibc_reboot_notifier_call':
   include/linux/kern_levels.h:4:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^
   include/linux/printk.h:252:9: note: in expansion of macro 'KERN_ERR'
     printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
            ^
>> drivers/firmware/efi/efi-bc.c:93:3: note: in expansion of macro 'pr_err'
      pr_err(
      ^
   include/linux/kern_levels.h:4:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^
   include/linux/printk.h:252:9: note: in expansion of macro 'KERN_ERR'
     printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
            ^
   drivers/firmware/efi/efi-bc.c:101:3: note: in expansion of macro 'pr_err'
      pr_err(
      ^

vim +/pr_err +93 drivers/firmware/efi/efi-bc.c

    77			goto out;
    78	
    79		name_efichar_blen = efi_char16_bufsz(LOADER_ENTRY_ONE_SHOT);
    80		cmd_efichar_blen = efi_char16_bufsz(cmd);
    81	
    82		name_efichar = kzalloc(name_efichar_blen, GFP_KERNEL);
    83		if (!name_efichar)
    84			goto out;
    85	
    86		cmd_efichar = kzalloc(cmd_efichar_blen, GFP_KERNEL);
    87		if (!cmd_efichar)
    88			goto out;
    89	
    90		if (efichar_from_char(
    91				name_efichar, LOADER_ENTRY_ONE_SHOT, name_efichar_blen)
    92				!= strlen(LOADER_ENTRY_ONE_SHOT)) {
  > 93			pr_err(
    94				"efibc: %s: Failed to convert char to efi_char16_t. length=%lu",
    95				__func__, name_efichar_blen);
    96			goto out;
    97		}
    98	
    99		if (efichar_from_char(cmd_efichar, cmd, cmd_efichar_blen)
   100				!= strlen(cmd)) {
   101			pr_err(

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (53467 bytes)