linux-kernel - Re: [PATCH v5 1/4] dt-bindings: power: reset: add document for reboot-mode driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJ+PGgr8MAYH8onEDX-6DRmVR+Y-iOcw=JUZ3rfeq1ieg@mail.gmail.com>
Date:	Fri, 18 Mar 2016 08:14:08 -0500
From:	Rob Herring <robh@...nel.org>
To:	Andy Yan <andy.yan@...k-chips.com>
Cc:	John Stultz <john.stultz@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Heiko Stübner <heiko@...ech.de>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Olof Johansson <olof@...om.net>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Sebastian Reichel <sre@...nel.org>,
	Jun Nie <jun.nie@...aro.org>,
	Eduardo Valentin <edubezval@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Will Deacon <will.deacon@....com>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Caesar Wang <wxt@...k-chips.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Moritz Fischer <moritz.fischer@...us.com>, richard@....at,
	David Woodhouse <dwmw2@...radead.org>,
	Julius Werner <jwerner@...gle.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: power: reset: add document for
 reboot-mode driver

On Fri, Mar 18, 2016 at 3:43 AM, Andy Yan <andy.yan@...k-chips.com> wrote:
> Hi Rob:
>
>
> On 2016年03月17日 23:52, Rob Herring wrote:
>>
>> On Tue, Mar 08, 2016 at 08:23:05PM +0800, Andy Yan wrote:
>>>
>>> add device tree bindings document for reboot-mode driver
>>>
>>> Signed-off-by: Andy Yan <andy.yan@...k-chips.com>

[...]

>>> +Required properties:
>>> +- compatible: should be "syscon-reboot-mode"
>>> +- offset: offset in the register map for the storage register (in bytes)
>>> +
>>> +Optional properity:
>>> +- mask: the mask bits of the mode magic value, default set to 0xffffffff
>>> if missing.
>>
>> I can't see how this is used. I would drop it for now.
>>
>> With that change:
>>
>> Acked-by: Rob Herring <robh@...nel.org>
>
>
> The mask is suggested by Moritz Fischer in V2[0]. And I found Tegra did
> indeed only use some bits of one register to store the reboot mode[1].

And the other bits in the register need to be preserved? Please make
it clear the mask is for the register, not the magic value.

There's also a typo with "properity".

Rob