linux-kernel - Re: [PATCH] nios2: Replace fdt_translate_address with of_flat_dt_translate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56EC0279.1010205@hurleysoftware.com>
Date:	Fri, 18 Mar 2016 06:28:25 -0700
From:	Peter Hurley <peter@...leysoftware.com>
To:	Ley Foon Tan <lftan@...era.com>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	nios2-dev@...ts.rocketboards.org, linux-kernel@...r.kernel.org,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH] nios2: Replace fdt_translate_address with
 of_flat_dt_translate_address

On 03/17/2016 10:58 PM, Ley Foon Tan wrote:
> On Thu, 2016-03-17 at 20:22 -0700, Peter Hurley wrote:
>> Hi Guenter,
>>
>> On 03/17/2016 07:49 PM, Guenter Roeck wrote:
>>> nios2 builds fail with the following build error.
>>>
>>> arch/nios2/kernel/prom.c: In function 'early_init_dt_scan_serial':
>>> arch/nios2/kernel/prom.c:100:2: error:
>>> 	implicit declaration of function 'fdt_translate_address'
>>>
>>> Commit c90fe9c0394b ("of: earlycon: Move address translation to
>>> of_setup_earlycon()") replaced fdt_translate_address() with
>>> of_flat_dt_translate_address() but missed updating the nios2 code.
>>
>> My bad.
>> The sad part is I even noted this other user of fdt_translate_address()
>> in a review of a different patch, and then overlooked it in my own patch. :/
>>
>> Reviewed-by: Peter Hurley <peter@...leysoftware.com>
>>
> Hi Peter,
> 
> Will you take this patch or you want me to take this?
> Thanks.

Please take this patch.

Regards,
Peter Hurley