linux-kernel - Re: [PATCH] ftrace: use kasprintf() in ftrace_profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160318103152.746b7bf5@gandalf.local.home>
Date:	Fri, 18 Mar 2016 10:31:52 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Geliang Tang <geliangtang@....com>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ftrace: use kasprintf() in ftrace_profile_tracefs()

On Tue, 15 Mar 2016 22:12:34 +0800
Geliang Tang <geliangtang@....com> wrote:

> Use kasprintf() instead of kmalloc() and snprintf().
> 
> Signed-off-by: Geliang Tang <geliangtang@....com>

Thanks, applied!

-- Steve

> ---
>  kernel/trace/ftrace.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 2ece9f1..69aceae 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -1030,8 +1030,7 @@ static __init void ftrace_profile_tracefs(struct dentry *d_tracer)
>  	for_each_possible_cpu(cpu) {
>  		stat = &per_cpu(ftrace_profile_stats, cpu);
>  
> -		/* allocate enough for function name + cpu number */
> -		name = kmalloc(32, GFP_KERNEL);
> +		name = kasprintf(GFP_KERNEL, "function%d", cpu);
>  		if (!name) {
>  			/*
>  			 * The files created are permanent, if something happens
> @@ -1043,7 +1042,6 @@ static __init void ftrace_profile_tracefs(struct dentry *d_tracer)
>  			return;
>  		}
>  		stat->stat = function_stats;
> -		snprintf(name, 32, "function%d", cpu);
>  		stat->stat.name = name;
>  		ret = register_stat_tracer(&stat->stat);
>  		if (ret) {