linux-kernel - Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160318153008.GC16489@kroah.com>
Date:	Fri, 18 Mar 2016 08:30:08 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Lu Baolu <baolu.lu@...ux.intel.com>
Cc:	Lee Jones <lee.jones@...aro.org>, Felipe Balbi <balbi@...nel.org>,
	Mathias Nyman <mathias.nyman@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD
 Driver

On Fri, Mar 18, 2016 at 04:43:21PM +0800, Lu Baolu wrote:
> 
> 
> On 03/18/2016 04:09 PM, Lee Jones wrote:
> > On Fri, 18 Mar 2016, Lu Baolu wrote:
> >
> >> Some Intel platforms have an USB port mux controlled by GPIOs.
> >> There's a single ACPI platform device that provides both USB ID
> >> extcon device and a USB port mux device. This MFD driver will
> >> split the 2 devices for their respective drivers.
> >>
> >> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> >> Suggested-by: David Cohen <david.a.cohen@...ux.intel.com>
> > This should be at the top.
> >
> > You couldn't have written the patch before it was suggested.
> 
> Yes. I will change this.
> 
> >
> >> Reviewed-by: Felipe Balbi <balbi@...nel.org>
> >> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > What is this sign-off meant to indicate?
> 
> Fengguang's sign-off was added due to folding a patch contributed by
> his kbuild robot.

No, you can't do that, he only signed off on his fixup patch, not your
overall larger patch!

I'm going to stop you now and require you to get this properly reviewed,
and signed-off-by some experienced Intel kernel developers before I look
at this at all.  Take advantage of the resources you have, don't force
the community to point out these basic mistakes.

Also, you know I'm not looking at new patches until after -rc1 is out,
so please wait until then before resending.

greg k-h