linux-kernel - Re: [PATCH] serial-uartlite: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160318184856.c289c591@kerio.vanmierlo.com>
Date:	Fri, 18 Mar 2016 18:48:56 +0100
From:	"Maarten Brock" <m.brock@...mierlo.com>
To:	"Geert Uytterhoeven" <geert@...ux-m68k.org>,
	"Sudip Mukherjee" <sudipm.mukherjee@...il.com>
Cc:	"Peter Korsgaard" <jacmet@...site.dk>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	"Jiri Slaby" <jslaby@...e.com>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial-uartlite: fix build warning

----- Original Message -----
From: Geert Uytterhoeven [mailto:geert@...ux-m68k.org]
To: Sudip Mukherjee [mailto:sudipm.mukherjee@...il.com]
Cc: Peter Korsgaard [mailto:jacmet@...site.dk], Greg Kroah-Hartman [mailto:gregkh@...uxfoundation.org], Jiri Slaby [mailto:jslaby@...e.com], linux-kernel@...r.kernel.org [mailto:linux-kernel@...r.kernel.org], linux-serial@...r.kernel.org [mailto:linux-serial@...r.kernel.org]
Sent: Fri, 18 Mar 2016 13:48:06 +0100
Subject: Re: [PATCH] serial-uartlite: fix build warning


> On Thu, Mar 10, 2016 at 2:14 PM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
> > We were getting build warnings about:
> > drivers/tty/serial/uartlite.c: In function ‘ulite_request_port’:
> > drivers/tty/serial/uartlite.c:348:21: warning: assignment discards
> >         'const' qualifier from pointer target type
> > port->private_data = &uartlite_be;
> >                      ^
> > drivers/tty/serial/uartlite.c:354:22: warning: assignment discards
> >         'const' qualifier from pointer target type
> > port->private_data = &uartlite_le;
> >                       ^
> >
> > Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le")
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> 
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert

Reverting is not the same as fixing.

Rant:
It is a stupid warning IMHO, but being a compiler writer myself (SDCC) I
understand how it can arise. If you assign some const pointer to a void
pointer without an explicit cast gcc does not complain about the complete
loss of type, but it does warn about losing constness. In general I'd say:
make up your mind; either warn about both or don't warn about either.

Maarten