linux-kernel - Re: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1603181932230.3978@nanos>
Date:	Fri, 18 Mar 2016 19:34:12 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Kan Liang <kan.liang@...el.com>
cc:	peterz@...radead.org, ak@...ux.intel.com, eranian@...gle.com,
	mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore
 modular

On Fri, 18 Mar 2016, kan.liang@...el.com wrote:

> From: Kan Liang <kan.liang@...el.com>
> 
> This patch makes Intel uncore pmu driver modular.
> By default, the uncore driver will be built in the kernel. If it is
> configured as module, the supported cpu model can be auto loaded.
> This patch also cleans up the code of cpu_init and pci_init.

Nice work!
 
> +static struct intel_uncore_init_fun skl_uncore_init = {
> +	.pci_init = skl_uncore_pci_init,
> +};
> +
> +static const struct x86_cpu_id intel_uncore_match[] = {

Shouldn't all of these structs be const __initconst?

Other than that:

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>