linux-kernel - Re: [PATCH] serial-uartlite: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160318203235.GA3560@kroah.com>
Date:	Fri, 18 Mar 2016 13:32:35 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Maarten Brock <m.brock@...mierlo.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Peter Korsgaard <jacmet@...site.dk>,
	Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial-uartlite: fix build warning

On Fri, Mar 18, 2016 at 12:19:40PM -0700, Peter Hurley wrote:
> On 03/18/2016 10:48 AM, Maarten Brock wrote:
> > ----- Original Message -----
> > From: Geert Uytterhoeven [mailto:geert@...ux-m68k.org]
> > To: Sudip Mukherjee [mailto:sudipm.mukherjee@...il.com]
> > Cc: Peter Korsgaard [mailto:jacmet@...site.dk], Greg Kroah-Hartman [mailto:gregkh@...uxfoundation.org], Jiri Slaby [mailto:jslaby@...e.com], linux-kernel@...r.kernel.org [mailto:linux-kernel@...r.kernel.org], linux-serial@...r.kernel.org [mailto:linux-serial@...r.kernel.org]
> > Sent: Fri, 18 Mar 2016 13:48:06 +0100
> > Subject: Re: [PATCH] serial-uartlite: fix build warning
> > 
> > 
> >> On Thu, Mar 10, 2016 at 2:14 PM, Sudip Mukherjee
> >> <sudipm.mukherjee@...il.com> wrote:
> >>> We were getting build warnings about:
> >>> drivers/tty/serial/uartlite.c: In function ‘ulite_request_port’:
> >>> drivers/tty/serial/uartlite.c:348:21: warning: assignment discards
> >>>         'const' qualifier from pointer target type
> >>> port->private_data = &uartlite_be;
> >>>                      ^
> >>> drivers/tty/serial/uartlite.c:354:22: warning: assignment discards
> >>>         'const' qualifier from pointer target type
> >>> port->private_data = &uartlite_le;
> >>>                       ^
> >>>
> >>> Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le")
> >>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> >>
> >> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> >>
> >> Gr{oetje,eeting}s,
> >>
> >>                         Geert
> > 
> > Reverting is not the same as fixing.
> 
> I agree; better to revert commit 2905697a82ea and let Maarten re-submit
> a patch that doesn't generate build warnings.

I'll fix this up after 4.6-rc1 is out, thanks.

greg k-h