linux-kernel - Re: [Outreachy kernel] [PATCH v2] iwlwifi: dvm: use alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160318204744.GN20028@mtj.duckdns.org>
Date:	Fri, 18 Mar 2016 16:47:44 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Eva Rachel Retuya <eraretuya@...il.com>
Cc:	outreachy-kernel@...glegroups.com, johannes.berg@...el.com,
	emmanuel.grumbach@...el.com, linuxwifi@...el.com,
	kvalo@...eaurora.org, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH v2] iwlwifi: dvm: use
 alloc_ordered_workqueue()

On Fri, Mar 18, 2016 at 12:19:21AM +0800, Eva Rachel Retuya wrote:
> Use alloc_ordered_workqueue() to allocate the workqueue instead of
> create_singlethread_workqueue() since the latter is deprecated and is scheduled
> for removal.
> 
> There are work items doing related operations that shouldn't be swapped when
> queued in a certain order hence preserve the strict execution ordering of a
> single threaded (ST) workqueue by switching to alloc_ordered_workqueue().
> 
> WQ_MEM_RECLAIM flag is not needed since the worker is not supposed to free
> memory.

I think "not depended during memory reclaim" probalby is a better way
to describe it.

> Signed-off-by: Eva Rachel Retuya <eraretuya@...il.com>

But other than that,

 Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun