linux-kernel - RE: [PATCH 1/3] aacraid: add missing curly braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <198D06D448A18D4E93F08FB849C4E39D7D218372@BBYEXM01.pmc-sierra.internal>
Date:	Fri, 18 Mar 2016 20:50:30 +0000
From:	Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...s.com>
To:	Arnd Bergmann <arnd@...db.de>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
	"James.Bottomley@...senPartnership.com" 
	<James.Bottomley@...senPartnership.com>,
	Adaptec OEM Raid Solutions <aacraid@...ptec.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>
CC:	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Johannes Thumshirn" <jthumshirn@...e.de>,
	Tomas Henzl <thenzl@...hat.com>,
	"Mahesh Rajashekhara" <Mahesh.Rajashekhara@...s.com>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: RE: [PATCH 1/3] aacraid: add missing curly braces


> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@...db.de]
> Sent: Monday, March 14, 2016 7:30 AM
> To: martin.petersen@...cle.com;
> James.Bottomley@...senPartnership.com; Adaptec OEM Raid Solutions;
> James E.J. Bottomley
> Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Arnd
> Bergmann; Johannes Thumshirn; Tomas Henzl; Mahesh Rajashekhara;
> Raghava Aditya Renukunta; Fengguang Wu
> Subject: [PATCH 1/3] aacraid: add missing curly braces
> 
> gcc-6 warns about obviously wrong indentation for newly added
> code in aac_slave_configure():
> 
> drivers/scsi/aacraid/linit.c: In function 'aac_slave_configure':
> drivers/scsi/aacraid/linit.c:458:3: warning: statement is indented as if it were
> guarded by... [-Wmisleading-indentation]
>    sdev->tagged_supported = 1;
>    ^~~~
> drivers/scsi/aacraid/linit.c:455:4: note: ...this 'else' clause, but it is not
> 
> gcc is correct, and evidently this was meant to be within the curly
> braces that should have been there to start with. This patch adds
> them, which avoids the warning and makes it clear what was intended
> here.
> 
> Nothing changes in behavior because in the 'if' block, the
> sdev->tagged_supported flag is known to be set already.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 6bf3b630d0a7 ("aacraid: SCSI blk tag support")
> ---
>  drivers/scsi/aacraid/linit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
> index 21a67ed047e8..ff6caab8cc8b 100644
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -452,10 +452,11 @@ static int aac_slave_configure(struct scsi_device
> *sdev)
>  		else if (depth < 2)
>  			depth = 2;
>  		scsi_change_queue_depth(sdev, depth);
> -	} else
> +	} else {
>  		scsi_change_queue_depth(sdev, 1);
>  		sdev->tagged_supported = 1;
> +	}
> 
>  	return 0;
>  }
> --
> 2.7.0

Reviewed-by: Raghava Aditya Renukunta < raghavaaditya.renukunta@...s.com >

Regards,
Raghava Aditya