linux-kernel - Re: [PATCH] nios2: Replace fdt_translate_address with of_flat_dt_translate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56EB7478.9080401@hurleysoftware.com>
Date:	Thu, 17 Mar 2016 20:22:32 -0700
From:	Peter Hurley <peter@...leysoftware.com>
To:	Guenter Roeck <linux@...ck-us.net>, Ley Foon Tan <lftan@...era.com>
Cc:	nios2-dev@...ts.rocketboards.org, linux-kernel@...r.kernel.org,
	Rob Herring <robh@...nel.org>
Subject: Re: [PATCH] nios2: Replace fdt_translate_address with
 of_flat_dt_translate_address

Hi Guenter,

On 03/17/2016 07:49 PM, Guenter Roeck wrote:
> nios2 builds fail with the following build error.
> 
> arch/nios2/kernel/prom.c: In function 'early_init_dt_scan_serial':
> arch/nios2/kernel/prom.c:100:2: error:
> 	implicit declaration of function 'fdt_translate_address'
> 
> Commit c90fe9c0394b ("of: earlycon: Move address translation to
> of_setup_earlycon()") replaced fdt_translate_address() with
> of_flat_dt_translate_address() but missed updating the nios2 code.

My bad.
The sad part is I even noted this other user of fdt_translate_address()
in a review of a different patch, and then overlooked it in my own patch. :/

Reviewed-by: Peter Hurley <peter@...leysoftware.com>


> Fixes: c90fe9c0394b ("of: earlycon: Move address translation to of_setup_earlycon()")
> Cc: Peter Hurley <peter@...leysoftware.com>
> Cc: Rob Herring <robh@...nel.org>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  arch/nios2/kernel/prom.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/nios2/kernel/prom.c b/arch/nios2/kernel/prom.c
> index 718dd197909f..367c5426157b 100644
> --- a/arch/nios2/kernel/prom.c
> +++ b/arch/nios2/kernel/prom.c
> @@ -97,8 +97,7 @@ static int __init early_init_dt_scan_serial(unsigned long node,
>  		return 0;
>  #endif
>  
> -	*addr64 = fdt_translate_address((const void *)initial_boot_params,
> -		node);
> +	*addr64 = of_flat_dt_translate_address(node);
>  
>  	return *addr64 == OF_BAD_ADDR ? 0 : 1;
>  }
>