linux-kernel - Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56EC744F.90308@suse.de>
Date:	Fri, 18 Mar 2016 22:34:07 +0100
From:	Andreas Färber <afaerber@...e.de>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	linux-kernel@...r.kernel.org
Cc:	Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Heiko Stuebner <heiko@...ech.de>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	linux-rockchip@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	Giuseppe Cavallaro <peppe.cavallaro@...com>
Subject: Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node

Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso:
> So the dwmac device manages to probe again.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
> ---
>  arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1ece66f3e162..4ba7ddecb478 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -101,6 +101,14 @@
>  	snps,reset-delays-us = <0 10000 30000>;
>  	rx_delay = <0x10>;
>  	tx_delay = <0x30>;
> +	mdio0 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "snps,dwmac-mdio";
> +		ethphy1: ethernet-phy@1 {
> +			reg = <1>;
> +		};
> +	};

This is a) ugly for lack of white lines in between, b) unnecessary since
this is being fixed in the stmmac driver where it will benefit more than
just this one SoM.

Regards,
Andreas

>  };
>  
>  &i2c0 {

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)