linux-kernel - Re: [PATCH v2] x86: dts: ce4100: Use defined compatible string for PCF8575 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160318214439.GA17481@rob-hp-laptop>
Date:	Fri, 18 Mar 2016 16:44:39 -0500
From:	Rob Herring <robh@...nel.org>
To:	Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:	linux-kernel@...r.kernel.org,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2] x86: dts: ce4100: Use defined compatible string for
 PCF8575 chip

On Wed, Mar 16, 2016 at 04:51:20PM +0000, Ben Hutchings wrote:
> The binding definition for the PCF857x GPIO expanders doesn't mention
> a "ti,pcf8575" compatible string.  This is apparently because TI is
> only a second source - there is no functional difference between
> PCF8575 chips manufactured by TI and NXP, and the same board might be
> populated with either depending on availability.
> 
> This is not a problem in practice because the I2C core uses
> of_modalias_node() before matching drivers and this strips the
> manufacturer name.
> 
> Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> ---
> v2: Correct the claim that this is a practical problem.
> 
>  Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++--
>  arch/x86/platform/ce4100/falconfalls.dts                     | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Acked-by: Rob Herring <robh@...nel.org>