[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3461345.ttUnIM4Vzr@vostro.rjw.lan>
Date: Sat, 19 Mar 2016 00:34:46 +0100
From: "Rafael J. Wysocki" <rjw@...ysocki.net>
To: Viresh Kumar <viresh.kumar@...aro.org>,
Richard Cochran <rcochran@...utronix.de>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Cc: linux-kernel@...r.kernel.org, rt@...utronix.de,
linux-pm@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq: Make cpufreq_quick_get() safe to call.
On Saturday, March 12, 2016 06:52:37 AM Viresh Kumar wrote:
> On 11-03-16, 09:43, Richard Cochran wrote:
> > The function, cpufreq_quick_get, accesses the global 'cpufreq_driver' and
> > its fields without taking the associated lock, cpufreq_driver_lock.
> >
> > Without the locking, nothing guarantees that 'cpufreq_driver' remains
> > consistent during the call. This patch fixes the issue by taking the lock
> > before accessing the data structure.
> >
> > Cc: Dirk Brandewie <dirk.brandewie@...il.com>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > Cc: Viresh Kumar <viresh.kumar@...aro.org>
> > Cc: linux-pm@...r.kernel.org
> > Signed-off-by: Richard Cochran <rcochran@...utronix.de>
> > ---
> > drivers/cpufreq/cpufreq.c | 12 ++++++++++--
> > 1 file changed, 10 insertions(+), 2 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
Applied, thanks!
Powered by blists - more mailing lists