linux-kernel - Re: [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 19 Mar 2016 19:38:27 +0000 (UTC)
From:	Paul Walmsley <paul@...an.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
cc:	tony@...mide.com, jarkko.nikula@...mer.com, t-kristo@...com,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for
 sidetone

On Fri, 18 Mar 2016, Peter Ujfalusi wrote:

> Hi,
> 
> Chanes since v1:
> - removed the ASoC patch as Mark has applied it already
> - Added my signed-off to the hwmod patch
> - New patch to handle the case when the sidetone hwmod has been removed for
>   legacy boot.
> 
> The series addresses a long standing issue with McBSP2/3 regarding to hwmod
> setup. When booting with DT a warning is printed that mcbsp2/3 is using two
> hwmod.
> The root of the issue is the way how the hwmod data was constructed in the first
> place for OMAP3 McBSP2/3.
> After re-reading the TRM it is clear that the sidetone should not have it's
> own hwmod data as it is not a separate IP, it is part of the McBSP module. It
> can not affect PRCM either since it's SYSCONFIG register's AUTOIDLE bit is only
> sets the autoidle from the internal McBSP_iclk clock to the sidetone block of
> the same McBSP.

NAK, at least without further discussion - see my comments on the v1 0/3 
introduction.

- Paul