linux-kernel - Re: [patch] ib_srpt: fix a WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56ECA8A0.5060502@sandisk.com>
Date:	Fri, 18 Mar 2016 18:17:20 -0700
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Doug Ledford <dledford@...hat.com>
CC:	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>,
	"Sagi Grimberg" <sagig@...lanox.com>,
	Alex Estrin <alex.estrin@...el.com>,
	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [patch] ib_srpt: fix a WARN_ON() message

On 03/17/16 22:41, Dan Carpenter wrote:
> The first argument of WARN_ON() is a condition, so it means the warning
> message here will just be the name without the ->qp_num information.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 1d13090..0bd3cb2 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc)
>   		if (srpt_set_ch_state(ch, CH_DISCONNECTED))
>   			schedule_work(&ch->release_work);
>   		else
> -			WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
> +			WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
>   	}
>   }

Reviewed-by: Bart Van Assche <bart.vanassche@...disk.com>