linux-kernel - Re: [PATCH] crypto: cleaning and refactoring in rsa.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160319080328.GA26605@gondor.apana.org.au>
Date:	Sat, 19 Mar 2016 16:03:28 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	maitesin <oscar.forner.martinez@...il.com>
Cc:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	maitesin <violador.de.segmentos@...il.com>
Subject: Re: [PATCH] crypto: cleaning and refactoring in rsa.c

On Fri, Mar 18, 2016 at 08:39:51PM +0000, maitesin wrote:
> * Removed several unused initializations of variables.
> * Inlined couple of functions.
> * rsa_check_key_length: changed to use only the switch statement.
> * rsa_setkey: refactored the implementation to be closer to the other
> functions in the file.
> 
> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@...il.com>

Nack.  I don't think this patch improves the code at all.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt