linux-kernel - [tip:x86/urgent] x86/topology: Fix logical package mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-b5d5f27d938fb6fc8d3202704e699d2694a02da6@git.kernel.org>
Date:	Sat, 19 Mar 2016 02:30:35 -0700
From:	tip-bot for Peter Zijlstra <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	peterz@...radead.org, umgwanakikbuti@...il.com,
	jencce.kernel@...il.com, linux-kernel@...r.kernel.org,
	hpa@...or.com, mingo@...nel.org, tglx@...utronix.de
Subject: [tip:x86/urgent] x86/topology: Fix logical package mapping

Commit-ID:  b5d5f27d938fb6fc8d3202704e699d2694a02da6
Gitweb:     http://git.kernel.org/tip/b5d5f27d938fb6fc8d3202704e699d2694a02da6
Author:     Peter Zijlstra <peterz@...radead.org>
AuthorDate: Fri, 18 Mar 2016 16:03:46 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Sat, 19 Mar 2016 10:26:40 +0100

x86/topology: Fix logical package mapping

That first branch testing pkg against __max_logical_packages is wrong,
because if the first pkg id is larger, then the find_first_zero will
find us logical package id 0. However, if the second pkg id is indeed
0, we'll again claim it without testing if it was already taken.

Also, it fails to print the mapping.

Fixes: 1f12e32f4cd5 ("x86/topology: Create logical package id")
Reported-by: Xiong Zhou <jencce.kernel@...il.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Cc: aherrmann@...e.com
Cc: bp@...en8.de
Cc: Mike Galbraith <umgwanakikbuti@...il.com>
Link: http://lkml.kernel.org/r/20160317095220.GO6344@twins.programming.kicks-ass.net
Link: http://lkml.kernel.org/r/20160318150538.482393396@infradead.org
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

---
 arch/x86/kernel/smpboot.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 643dbdc..64b669d 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -274,11 +274,6 @@ int topology_update_package_map(unsigned int apicid, unsigned int cpu)
 	if (test_and_set_bit(pkg, physical_package_map))
 		goto found;
 
-	if (pkg < __max_logical_packages) {
-		set_bit(pkg, logical_package_map);
-		physical_to_logical_pkg[pkg] = pkg;
-		goto found;
-	}
 	new = find_first_zero_bit(logical_package_map, __max_logical_packages);
 	if (new >= __max_logical_packages) {
 		physical_to_logical_pkg[pkg] = -1;