linux-kernel - Re: [PATCH 3/3] infiniband: IB/hns: add Hisilicon RoCE support with bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56ED349A.8060806@huawei.com>
Date:	Sat, 19 Mar 2016 19:14:34 +0800
From:	oulijun <oulijun@...wei.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	<dledford@...hat.com>, <sean.hefty@...el.com>,
	<hal.rosenstock@...il.com>, <davem@...emloft.net>,
	<jeffrey.t.kirsher@...el.com>, <jiri@...lanox.com>,
	<ogerlitz@...lanox.com>
CC:	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <gongyangming@...wei.com>,
	<xiaokun@...wei.com>, <tangchaofei@...wei.com>,
	<haifeng.wei@...wei.com>, <yisen.zhuang@...wei.com>,
	<yankejian@...wei.com>, <lisheng011@...wei.com>,
	<charles.chenxin@...wei.com>, <linuxarm@...wei.com>
Subject: Re: [PATCH 3/3] infiniband: IB/hns: add Hisilicon RoCE support with
 bindings

On 2016/3/11 21:39, Sergei Shtylyov wrote:
> Hello.
> 
> On 3/11/2016 1:37 PM, Lijun Ou wrote:
> 
>> This submit add binding file and dts file.
> 
>    I see no .dts file.
> 
>>
>> Signed-off-by: Lijun Ou <oulijun@...wei.com>
>> Signed-off-by: Wei Hu(Xavier) <xavier.huwei@...wei.com>
>> ---
>>   .../bindings/infiniband/hisilicon-hns-roce.txt     | 68 ++++++++++++++++++++++
>>   1 file changed, 68 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>>
>> diff --git a/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>> new file mode 100644
>> index 0000000..8004641
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>> @@ -0,0 +1,68 @@
>> +HiSilicon RoCE DT description
>> +
>> +HiSilicon RoCE engine is a part of network subsystem.
>> +It works depending on other part of network wubsytem, such as, gmac and
> 
>    Subsystem.
> 
>> +dsa fabric.
>> +
>> +Additional properties are described here:
>> +
>> +Required properties:
>> +- compatible: Should contain "hisilicon,hns-roce-v1".
>> +- reg: Physical base address of the roce driver and
>> +length of memory mapped region.
>> +- eth-handle: phandle, specifies a reference to a node
>> +representing a ethernet device.
>> +- dsaf-handle: phandle, specifies a reference to a node
>> +representing a dsaf device.
>> +- #address-cells: must be 2
>> +- #size-cells: must be 2
>> +Optional properties:
>> +- dma-coherent: Present if DMA operations are coherent.
>> +- interrupt-parent: the interrupt parent of this device.
>> +- interrupts: should contain 32 completion event irq,1 async event irq
>> +and 1 event overflow irq.
> 
>    The "interrupt-names" prop is strongly desired with some many IRQs.
> 
>> +Example:
>> +    rocee@...4000000 {
> 
>    The node names should be generic, not implementation specific.
> 
> [...]
> 
> MBR, Sergei
> 
> 
> .
> 
Hi Sergei Shtylyov , thanks for reviewing

I have modified it, I will send a new patch at soon

thanks
Lijun Ou