linux-kernel - Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458488880.4228.37.camel@perches.com>
Date:	Sun, 20 Mar 2016 08:48:00 -0700
From:	Joe Perches <joe@...ches.com>
To:	Parth Sane <laerdevstudios@...il.com>, gregkh@...uxfoundation.org
Cc:	Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
	luisbg@....samsung.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, amitoj1606@...il.com
Subject: Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment

On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote:
> Fixed multiple parenthesis alignment warnings.
> Signed-off-by: Parth Sane <laerdevstudios@...il.com>

Please always add a blank line after your changelog and
before your "Signed-off-by:" line

> diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
[]
> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
>  						       0x0000ffff);
>  			memcpy(ppayload, ptr, dump_imem_sz);
>  			r8712_write_mem(padapter, RTL8712_DMA_VOQ,
> -				  dump_imem_sz + TXDESC_SIZE,
> +					dump_imem_sz + TXDESC_SIZE,
>  				  (u8 *)ptx_desc);

Please align all lines of multi-line statements.

checkpatch is a stupid little script.
You have to make sure your own patches are sensible.

There are several things you should read and
understand in the Documentation directory.

	Documentation/CodingStyle
	Documentation/SubmittingPatches
	Documentation/SubmitChecklist

Fixing checkpatch messages is sometimes a decent
way to understand this process, but the patches
that can be generated fixing these messages tend
to have low overall value.

After doing a few of these, please move on to
some part of the kernel that interests you and
submit new code or start to fix actual defects.

Maybe if you are interested in wireless drivers,
buy a NIC that isn't supported by the mac80211
drivers and adapt the existing staging driver for
that variant.

Code, test, validate, submit, repeat...