linux-kernel - Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458489518.29161.3.camel@paulk.fr>
Date:	Sun, 20 Mar 2016 16:58:38 +0100
From:	Paul Kocialkowski <contact@...lk.fr>
To:	Tony Lindgren <tony@...mide.com>
Cc:	linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Benoît Cousson <bcousson@...libre.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Javier Martinez Canillas <javier@...hile0.org>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic
 support

Hi,

Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> Hi,
> 
> * Paul Kocialkowski <contact@...lk.fr> [160228 04:40]:
> > 
> > The LG Optimus Black codename sniper is a smartphone that was designed and
> > manufactured by LG Electronics (LGE) and released back in 2011.
> > It is using an OMAP3630 SoC, GP version.
> > 
> > This adds devicetree support for the device, with only a few basic features
> > supported, such as debug uart, i2c, internal emmc and external mmc.
> ...
> > 
> > +&i2c1 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&i2c1_pins>;
> > +
> > +	clock-frequency = <2600000>;
> > +
> > +	twl: twl@48 {
> > +		reg = <0x48>;
> > +		interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> > +		interrupt-parent = <&intc>;
> > +
> > +		power {
> > +			compatible = "ti,twl4030-power";
> > +			ti,use_poweroff;
> > +		};
> > +	};
> > +};
> Chances are this devices supports cutting off the voltages and
> the high frequency oscillator during idle. So you may want to
> at some point set compatible = "ti,twl4030-power-idle-osc-off"
> here.
> 
> Anyways, applying the dts changes into omap-for-v4.6/dt thanks.

It seems that v3 of this patch was merged into your tree instead of v4, which
contains some improvements over v3.

Should I submit a cleanup patch with the diff or can you use v4 instead (if not
too late)?

Cheers,

-- 
Paul Kocialkowski, low-level free software developer on embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)