linux-kernel - Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzHPXcQT8XXy7=PAvaaN9d6uzu9JYN0nrtSPYWmr+=bWA@mail.gmail.com>
Date:	Sun, 20 Mar 2016 12:13:47 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Christoph Lameter <cl@...ux.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Vineet Gupta <vgupta@...opsys.com>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and
 page_cache_{get,release} macros

On Sun, Mar 20, 2016 at 12:00 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>>
>> It doesn't help legibility or testing, so let's just do it in one big go.
>
> Might make sense splitting it by the thing being removed, though - easier
> to visually verify that it's doing the right thing when all replacements
> are of the same sort...

Yeah, that might indeed make each patch easier to read, and if
something goes wrong (which looks unlikely, but hey, shit happens), it
also makes it easier to see just what went wrong.

            Linus