linux-kernel - Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.11.1603201503400.20523@eggly.anvils>
Date:	Sun, 20 Mar 2016 15:21:27 -0700 (PDT)
From:	Hugh Dickins <hughd@...gle.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Al Viro <viro@...iv.linux.org.uk>,
	Christoph Lameter <cl@...ux.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Vineet Gupta <vgupta@...opsys.com>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH 01/71] arc: get rid of PAGE_CACHE_* and page_cache_{get,release}
 macros

On Sun, 20 Mar 2016, Linus Torvalds wrote:
> On Sun, Mar 20, 2016 at 12:34 PM, Kirill A. Shutemov
> <kirill.shutemov@...ux.intel.com> wrote:
> >
> > Hm. Okay. Re-split this way would take some time. I'll post updated
> > patchset tomorrow.
> 
> Oh, I was assuming this was automated with coccinelle or at least some
> simple shell scripting..
> 
> Generally, for things like this, automation really is great.
> 
> In fact, I like it when people attach the scripts to the commit
> message, further clarifying exactly what they did (even if the end
> result then often includes manual fixups for patterns that didn't
> _quite_ match, or where the automated script just generated ugly
> indentation or similar).

Fine by me to make these changes - once upon a time I had a better
grip than most of when and how to use PAGE_CACHE_blah; but have long
lost it, and agree with all those who find the imaginary distinction
now a drag.

Just a plea, which I expect you already intend, to apply these changes
either just before 4.6-rc1 or just before 4.7-rc1 (I think I'd opt for
4.6-rc1 myself), without any interim of days or months in linux-next,
where a period of divergence would be quite tiresome.  Holding back
Kirill's 71/71 until the coast is clear just a little later.

Thanks,
Hugh