linux-kernel - Re: Nokia N900 - audio TPA6130A2 problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160320051704.GA12934@earth>
Date:	Sun, 20 Mar 2016 06:17:04 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
Cc:	Peter Ujfalusi <peter.ujfalusi@...com>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Pali Rohár <pali.rohar@...il.com>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	Tony Lindgren <tony@...mide.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Pavel Machek <pavel@....cz>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Nishanth Menon <nm@...com>, merlijn@...zup.org
Subject: Re: Nokia N900 - audio TPA6130A2 problems

Hi,

On Sat, Mar 19, 2016 at 10:49:57AM +0200, Ivaylo Dimitrov wrote:
> On 18.03.2016 17:04, Sebastian Reichel wrote:
> >On Fri, Mar 18, 2016 at 03:45:26PM +0200, Ivaylo Dimitrov wrote:
> >>On 18.03.2016 15:36, Sebastian Reichel wrote:
> >>Regulator is V28_A, which is always-on, so it is enabled no matter what
> >>probe does. Anyway, I added a various delays after regulator_enable(), to no
> >>success.
> 
> I guess we're getting closer - I put some printks in various functions in
> the twl-regulator.c, here is the result:
> 
> on power-up:
> 
> [    2.378601] twl4030ldo_get_voltage_sel VMMC2 vsel 0x00000008
> [    2.384948] twl4030reg_enable VMMC2 grp 0x00000020
> [    2.408416] twl4030ldo_get_voltage_sel VMMC2 vsel 0x00000008
> [    7.196685] twl4030reg_is_enabled VMMC2 state 0x0000002e
> [    7.202819] twl4030reg_is_enabled VMMC2 state 0x0000002e
> [    7.209777] twl4030reg_is_enabled VMMC2 state 0x0000002e
> [    7.215728] twl4030reg_is_enabled VMMC2 state 0x0000002e
> [    7.223205] twl4030reg_is_enabled VMMC2 state 0x0000002e

Ok, so normal power up results in running VMMC2 (always-on works),
but voltage is not configured correctly. 2.6V is default according
to the TRM. I think this is a "bug" in the regulator framework. It
should setup the minimum allowed voltage before enabling the
always-on regulator.

In case of the tpa6130a2/tpa6140a2 driver it may also be nice to add
something like this to the driver (Vdd may be between 2.5V and 5.5V
according to both datasheets):

if (regulator_can_change_voltage(data->supply))
    regulator_set_voltage(data->supply, 2500000, 5500000);

> after restart from stock kernel:
> 
> [    2.388610] twl4030ldo_get_voltage_sel VMMC2 vsel 0x0000000a
> [    2.394958] twl4030reg_enable VMMC2 grp 0x00000028

I had a quick glance at this. I think stock kernel put VMMC2
into sleep mode. Mainline kernel does not expect sleep mode
being set and does not disable it.

> [    2.418426] twl4030ldo_get_voltage_sel VMMC2 vsel 0x0000000a
> [    7.186645] twl4030reg_is_enabled VMMC2 state 0x00000020
> [    7.192718] twl4030reg_is_enabled VMMC2 state 0x00000020
> [    7.199615] twl4030reg_is_enabled VMMC2 state 0x00000020
> [    7.205535] twl4030reg_is_enabled VMMC2 state 0x00000020
> [    7.212951] twl4030reg_is_enabled VMMC2 state 0x00000020
> 
> I don't see twl4030ldo_set_voltage_sel() for VMMC2(V28_A) regulator, though
> there are calls for VMMC1 and VAUX3.

I guess that's because the voltage is only configured if at least
one regulator consumer requests anything specific.

> So, it seems to me that V28_A is not enabled or correctly set-up
> and all devices connected to it does not function. And it looks
> like even after power-on VMMC2 is not correctly set-up - it is
> supposed to have voltage of 2.85V (10) but kernel leaves it to
> 2.60V (8). However my twl-fu ends here so any help is appreciated.

So in case of reboot from stock kernel voltage is already configured
to 2.8V, but it does not work, because of the sleep mode.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)