linux-kernel - Re: [PATCH v2 3/5] dt-bindings: Add documentation for GM20B GPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Mar 2016 15:55:49 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Rob Herring <robh@...nel.org>
Cc:	Alexandre Courbot <acourbot@...dia.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v2 3/5] dt-bindings: Add documentation for GM20B GPU

On Sat, Mar 19, 2016 at 5:47 AM, Rob Herring <robh@...nel.org> wrote:
> On Tue, Mar 15, 2016 at 11:58:42AM +0900, Alexandre Courbot wrote:
>> GM20B's definition is mostly similar to GK20A's, but requires an
>> additional clock.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
>> ---
>>  .../devicetree/bindings/gpu/nvidia,gk20a.txt       | 27 ++++++++++++++++++++--
>>  1 file changed, 25 insertions(+), 2 deletions(-)
>
> Acked-by: Rob Herring <robh@...nel.org>
>
> One nit below.
>
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>> index 1e3748337319..d9ad6b87fbbc 100644
>> --- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>> +++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt
>> @@ -1,9 +1,10 @@
>> -NVIDIA GK20A Graphics Processing Unit
>> +NVIDIA Tegra Graphics Processing Units
>>
>>  Required properties:
>>  - compatible: "nvidia,<gpu>"
>>    Currently recognized values:
>>    - nvidia,gk20a
>> +  - nvidia,gm20b
>>  - reg: Physical base address and length of the controller's registers.
>>    Must contain two entries:
>>    - first entry for bar0
>> @@ -19,6 +20,9 @@ Required properties:
>>  - clock-names: Must include the following entries:
>>    - gpu
>>    - pwr
>> +If the compatible string is "nvidia,gm20b", then the following clock
>> +is also required:
>> +  - ref
>>  - resets: Must contain an entry for each entry in reset-names.
>>    See ../reset/reset.txt for details.
>>  - reset-names: Must include the following entries:
>> @@ -27,7 +31,7 @@ Required properties:
>>  Optional properties:
>>  - iommus: A reference to the IOMMU. See ../iommu/iommu.txt for details.
>>
>> -Example:
>> +Example for GK20A:
>>
>>       gpu@0,57000000 {
>>               compatible = "nvidia,gk20a";
>> @@ -45,3 +49,22 @@ Example:
>>               iommus = <&mc TEGRA_SWGROUP_GPU>;
>>               status = "disabled";
>>       };
>> +
>> +Example for GM20B:
>> +
>> +     gpu@0,57000000 {
>
> Drop the comma and leading zero.

Even though this is how it appears in the actual DT?