linux-kernel - Re: [PATCH 1/1] Btrfs: Code Cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56EFB0EE.6030605@oracle.com>
Date:	Mon, 21 Mar 2016 16:29:34 +0800
From:	Anand Jain <anand.jain@...cle.com>
To:	Flex Liu <fliu@...ell.com>, David Sterba <dsterba@...e.com>
Cc:	linux-btrfs@...r.kernel.org, Chris Mason <clm@...com>,
	Josef Bacik <jbacik@...com>, linux-kernel@...r.kernel.org,
	Petr Tesarik <ptesarik@...e.com>, Flex Liu <fliu@...e.com>
Subject: Re: [PATCH 1/1] Btrfs: Code Cleanup



Hi Flex,


> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 366b335..5c16f04 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2325,7 +2325,10 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
>   	if (seeding_dev) {
>   		sb->s_flags &= ~MS_RDONLY;

  This is not undone in the failure code. Theoretically
  it should report error during unmount, did you notice ?

  (in general, $subject can be more specific).

Thanks, Anand

>   		ret = btrfs_prepare_sprout(root);
> -		BUG_ON(ret); /* -ENOMEM */
> +		if (ret) {
> +			btrfs_abort_transaction(trans, root, ret);
> +			goto error_trans;
> +		}
>   	}
>
>   	device->fs_devices = root->fs_info->fs_devices;
>