| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <145856702799.21117.16071591313990261661.stgit@woodpecker.blarg.de> Date: Mon, 21 Mar 2016 14:30:28 +0100 From: Max Kellermann <max@...mpel.org> To: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org Subject: [PATCH 3/6] drivers/media/media-devnode: clear private_data before put_device() Callbacks invoked from put_device() may free the struct media_devnode pointer, so any cleanup needs to be done before put_device(). Signed-off-by: Max Kellermann <max@...mpel.org> --- drivers/media/media-devnode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c index 4d7e8dd..e263816 100644 --- a/drivers/media/media-devnode.c +++ b/drivers/media/media-devnode.c @@ -196,10 +196,11 @@ static int media_release(struct inode *inode, struct file *filp) if (mdev->fops->release) mdev->fops->release(filp); + filp->private_data = NULL; + /* decrease the refcount unconditionally since the release() return value is ignored. */ put_device(&mdev->dev); - filp->private_data = NULL; return 0; }
Powered by blists - more mailing lists