linux-kernel - Re: [PATCH v5 3/6] module: s390: keep mod_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1603211449030.12175@pobox.suse.cz>
Date:	Mon, 21 Mar 2016 14:49:11 +0100 (CET)
From:	Miroslav Benes <mbenes@...e.cz>
To:	Jessica Yu <jeyu@...hat.com>
cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Petr Mladek <pmladek@...e.com>, Jiri Kosina <jikos@...nel.org>,
	Jonathan Corbet <corbet@....net>, linux-api@...r.kernel.org,
	live-patching@...r.kernel.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v5 3/6] module: s390: keep mod_arch_specific for livepatch
 modules

On Wed, 16 Mar 2016, Jessica Yu wrote:

> Livepatch needs to utilize the symbol information contained in the
> mod_arch_specific struct in order to be able to call the s390
> apply_relocate_add() function to apply relocations. Keep a reference to
> syminfo if the module is a livepatch module. Remove the redundant vfree()
> in module_finalize() since module_arch_freeing_init() (which also frees
> those structures) is called in do_init_module(). If the module isn't a
> livepatch module, we free the structures in module_arch_freeing_init() as
> usual.
> 
> Signed-off-by: Jessica Yu <jeyu@...hat.com>

Reviewed-by: Miroslav Benes <mbenes@...e.cz>