linux-kernel - Re: [PATCH 1/6] drivers/media/dvb-core/en50221: move code to dvb_ca_private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Mar 2016 21:55:55 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Max Kellermann <max@...mpel.org>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 1/6] drivers/media/dvb-core/en50221: move code to
 dvb_ca_private_free()

Hi Max,

[auto build test WARNING on v4.5-rc7]
[also build test WARNING on next-20160321]
[cannot apply to sailus-media/master linuxtv-media/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Max-Kellermann/drivers-media-dvb-core-en50221-move-code-to-dvb_ca_private_free/20160321-213556
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   drivers/media/dvb-core/dvb_ca_en50221.c: In function 'dvb_ca_private_free':
>> drivers/media/dvb-core/dvb_ca_en50221.c:167:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     unsigned int i;
     ^

vim +167 drivers/media/dvb-core/dvb_ca_en50221.c

   151		/* Flag indicating the thread should wake up now */
   152		unsigned int wakeup:1;
   153	
   154		/* Delay the main thread should use */
   155		unsigned long delay;
   156	
   157		/* Slot to start looking for data to read from in the next user-space read operation */
   158		int next_read_slot;
   159	
   160		/* mutex serializing ioctls */
   161		struct mutex ioctl_mutex;
   162	};
   163	
   164	static void dvb_ca_private_free(struct dvb_ca_private *ca)
   165	{
   166		dvb_unregister_device(ca->dvbdev);
 > 167		unsigned int i;
   168		for (i = 0; i < ca->slot_count; i++) {
   169			vfree(ca->slot_info[i].rx_buffer.data);
   170		}
   171		kfree(ca->slot_info);
   172		kfree(ca);
   173	}
   174	
   175	static void dvb_ca_en50221_thread_wakeup(struct dvb_ca_private *ca);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (44058 bytes)