linux-kernel - Re: [PATCH 1/4] vfs: add file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160321052252.GG17997@ZenIV.linux.org.uk>
Date:	Mon, 21 Mar 2016 05:22:53 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Theodore Ts'o <tytso@....edu>, Miklos Szeredi <miklos@...redi.hu>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	dhowells@...hat.com, Goldwyn Rodrigues <rgoldwyn@...e.com>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	stable@...r.kernel.org, Daniel Axtens <dja@...ens.net>
Subject: Re: [PATCH 1/4] vfs: add file_dentry()

On Mon, Mar 21, 2016 at 01:02:15AM -0400, Theodore Ts'o wrote:

> I have this patch in the ext4.git tree, but I'd like to get an
> Acked-by from Al before I send a pull request to Linus.
> 
> Al?  Any objections to my sending in this change via the ext4 tree?
> 						- Ted

FWIW, I would rather add DCACHE_OP_REAL (set at d_set_d_op()
time) and turned that into

static inline struct dentry *d_real(const struct dentry *dentry)
{
	if (unlikely(dentry->d_flags & DCACHE_OP_NATIVE_DENTRY))
		returd dentry->d_op->d_real(dentry);
	else
		return dentry;
}
static inline struct dentry *file_dentry(const struct file *file)
{
	return d_real(file->f_path.dentry);
}

and used ovl_dentry_real as ->d_real for overlayfs.  Miklos, do you
see any problems with that variant?