linux-kernel - Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160321220528.GE5083@two.firstfloor.org>
Date:	Mon, 21 Mar 2016 23:05:28 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Andi Kleen <andi@...stfloor.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	X86 ML <x86@...nel.org>, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base

> Please add a patch before this one that renames gs to gsbase.  This is
> unreadable as is.

I investigated this now, and it's not straight forward because on 32bit
->gs is actually gsindex, not gsbase. So with a straight rename you
would end up with index in base on 32bit, which would be confusing.

Perhaps this could be cleaned up at some point, switching 32bit
to use ->gsindex. But not right now, seems somewhat risky,
and I don't want to make it part of this patch kit.

FWIW I think it's readable.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.