[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160321221549.GG5083@two.firstfloor.org>
Date: Mon, 21 Mar 2016 23:15:49 +0100
From: Andi Kleen <andi@...stfloor.org>
To: Andy Lutomirski <luto@...capital.net>
Cc: Andi Kleen <andi@...stfloor.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
X86 ML <x86@...nel.org>, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base
On Mon, Mar 21, 2016 at 03:08:46PM -0700, Andy Lutomirski wrote:
> On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen <andi@...stfloor.org> wrote:
> >> Please add a patch before this one that renames gs to gsbase. This is
> >> unreadable as is.
> >
> > I investigated this now, and it's not straight forward because on 32bit
> > ->gs is actually gsindex, not gsbase. So with a straight rename you
> > would end up with index in base on 32bit, which would be confusing.
> >
>
> I would take this inconsistency as a reason why this needs to be fixed
> before any further changes are made.
The patchkit doesn't change anything for 32bit, so any inconsistency
in 32bit is completely orthogonal.
I don't see how adding a bazillion unrelated changes makes this
patchkit any better.
>
> The variables should be called "gsbase" and "gsindex", full stop.
> It's not particularly risky -- we could even compare the generated
> code if we cared.
Iff you can catch all the ifdefs ...
I looked through the grep hits and I don't think it's straight forward.
-Andi
--
ak@...ux.intel.com -- Speaking for myself only.
Powered by blists - more mailing lists