linux-kernel - Re: [PATCH] gpio: 74x164: Implement gpiochip.set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda38uz2dDwyCPA4YucfMS3Jjjkz00oPOmmkK7rXZatRNg@mail.gmail.com>
Date:	Tue, 22 Mar 2016 11:56:50 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Phil Reid <preid@...ctromag.com.au>, Axel Lin <axel.lin@...ics.com>
Cc:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Alexandre Courbot <gnurou@...il.com>,
	Gabor Juhos <juhosg@...nwrt.org>,
	Miguel Gaio <miguel.gaio@...xo.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: 74x164: Implement gpiochip.set_multiple()

On Tue, Mar 15, 2016 at 5:04 AM, Phil Reid <preid@...ctromag.com.au> wrote:

> pca953x does not update the cached data unless the write operation
> was successful. Which I folowed with the implement of set_multiple.
> However a number of other drivers update regardless.
> eg chip->buffer is updated even if the write_config fails.
>
> What is the preferred approach?

Obviously the other drivers are buggy and need to be fixed.
It can't be too many since the number of drivers with failable
write operations aren's so many. (And I guess they seldom fail
so it's not a big real world problem.) But it should be fixed.

Add Axel Lin to the thread, he's awesome at finding semantic
bugs.

Patches accepted :)

Yours,
Linus Walleij